异味代码处理

zd-modules/zd-modules-laboratory/src/main/java/com/zd/laboratory/service/impl/LabSensorServiceImpl.java

@@ -32,7 +32,6 @@ import java.util.concurrent.TimeUnit;
  */
 @Service
 public class LabSensorServiceImpl implements ILabSensorService {
-    private static Logger logger = LoggerFactory.getLogger(LabSensorServiceImpl.class);
     @Autowired
     private LabSensorMapper labSensorMapper;
     @Autowired
@@ -140,7 +139,6 @@ public class LabSensorServiceImpl implements ILabSensorService {
         Object subjectStr=redisService.getCacheObject(getKey(GatewayNum));
         Long subId=null;
         if(null!=subjectStr && !"".equals(subjectStr) ){
-            //logger.error("num:"+GatewayNum+"subjectStr:"+subjectStr);
             subId=Long.parseLong(subjectStr.toString());
         }
 
@@ -166,7 +164,6 @@ public class LabSensorServiceImpl implements ILabSensorService {
             subId=aLong;
             redisService.setCacheObject(getKey(GatewayNum),aLong,5L, TimeUnit.MINUTES);
         }
-        //logger.error("num:"+GatewayNum+"subId:"+subId);
         return subId;
     }
 
@@ -182,13 +179,10 @@ public class LabSensorServiceImpl implements ILabSensorService {
         labSensor.setUpdateTime(DateUtils.getNowDate());
         LabSensor old = labSensorMapper.selectLabSensorById(labSensor.getId());
         int i = labSensorMapper.updateLabSensor(labSensor);
-        if(i==1)
+        if(i==1 && old.getGatewayId()!=null)
         //需要删除旧的key
         {
-            if(old.getGatewayId()!=null)
-            {
-                redisService.deleteObject(getKey(old.getGatewayId()));
-            }
+            redisService.deleteObject(getKey(old.getGatewayId()));
         }
         return i;
     }